Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix popup show no profile #2342

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

yoshino-s
Copy link

What does this PR do?

(Note: Translations and typo fixes should be done on https://hosted.weblate.org/projects/switchyomega/ instead of PR.)

In some case there may be no profile shown in popup menu like

776769539a6d95448135782a5f74ebd

And we can find error like this

Uncaught TypeError: Cannot read properties of undefined (reading 'FixedProfile')
    at compareProfile (profiles.js:43:25)
    at Array.sort (<anonymous>)
    at addProfilesItems (profiles.js:145:8)
    at updateMenuByState (profiles.js:36:5)
    at v.ready (script.min.js:formatted:95:14)
    at profiles.js:2:11
    at profiles.js:283:3

Ref: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/var#var_hoisting

Compatibility

  • Is this PR compatible with old versions? Y
  • Can users simply upgrade the extension? Y

@yoshino-s
Copy link
Author

Hello? CI made an error but it's seems not because of my commit? maybe like error in deps or ci script?

@clamx4
Copy link

clamx4 commented Aug 4, 2024

This repo seems to be no longer maintained. Maybe we can move to https://github.com/suziwen/ZeroOmega

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants