Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial refines #1744

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Trivial refines #1744

wants to merge 4 commits into from

Conversation

yfdyh000
Copy link
Contributor

What does this PR do?

  • Bug fix
  • Improvement
  • New feature
  1. 补全缺失的翻译。没改其他语言(太多了),不知道翻译平台能否自动补全。正常来说应该是一个en.pot和一堆.po。
  2. 代码逻辑简化。没使用直接title的参数简写,那好像是ES6的某个语法,没查到名称和兼容性。
  3. 修改样式后,弹出面板中的‘网络异常’域名添加,下拉列表能正常扩展弹出窗的大小了。
  4. 之前允许用户查看、选中,但无法复制已订阅规则的内容,操作不友好。
    仅测试了Firefox Nightly。

Compatibility

Is this PR compatible with old versions? Can users simply upgrade the extension?
Yes.
Please describe any possible breaking changes (or surprising UX differences).
Better UX.

remark: Customize a function to avoid "Line exceeds maximum allowed length"
This also allows to 'add' while the dropdown list are expanded.
@sn-o-w sn-o-w mentioned this pull request May 6, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant