Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 0.9.0 #2239

Open
wants to merge 442 commits into
base: master
Choose a base branch
from
Open

release 0.9.0 #2239

wants to merge 442 commits into from

Conversation

fedml-alex
Copy link
Collaborator

No description provided.

alaydshah and others added 30 commits June 6, 2024 05:03
[CoreEngine] remove the deprecated files in the scheduler.
[Deploy] Recursively find the model serving package folder
…n Windows OS.
2. fixed the issue the sqlite path is illegal in Windows OS.
[CoreEngine] 1. fixed the issue that the fork method is not support i…
…counter

Adding hash set for counting the number of pending requests per endpoint.
…d_urls

Moving from storage object to presigned URLs
[Deploy] Refactor the quick start example, use public ip as default.
…ed architecture that supports Launch Master, Launch Slave, Deploy Master, and Deploy Slave at the same time.
update dev/0.7.0 to charlie dev branch
Deployment and Inference Module Performance Optimization Project
logging.info("=" * 80)
logging.info("[Device Model Deployment] Creating container with following parameters:")
logging.info("=" * 80)
logging.info("Image: {}".format(inference_image_name))

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High

This expression logs
sensitive data (password)
as clear text.

Copilot Autofix AI 26 days ago

To fix the problem, we should avoid logging any potentially sensitive information. Instead of logging the inference_image_name directly, we can log a sanitized version or avoid logging it altogether. We should also review other logging statements to ensure no sensitive information is being logged.

The best way to fix this without changing existing functionality is to sanitize the inference_image_name before logging it. We can replace sensitive parts of the string with a placeholder or simply avoid logging it if it contains sensitive information.

Suggested changeset 1
python/fedml/computing/scheduler/model_scheduler/device_model_deployment.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/python/fedml/computing/scheduler/model_scheduler/device_model_deployment.py b/python/fedml/computing/scheduler/model_scheduler/device_model_deployment.py
--- a/python/fedml/computing/scheduler/model_scheduler/device_model_deployment.py
+++ b/python/fedml/computing/scheduler/model_scheduler/device_model_deployment.py
@@ -223,3 +223,4 @@
         logging.info("=" * 80)
-        logging.info("Image: {}".format(inference_image_name))
+        sanitized_inference_image_name = inference_image_name.replace(registry_user_password, "****") if registry_user_password in inference_image_name else inference_image_name
+        logging.info("Image: {}".format(sanitized_inference_image_name))
         logging.info("Container name: {}".format(default_server_container_name))
EOF
@@ -223,3 +223,4 @@
logging.info("=" * 80)
logging.info("Image: {}".format(inference_image_name))
sanitized_inference_image_name = inference_image_name.replace(registry_user_password, "****") if registry_user_password in inference_image_name else inference_image_name
logging.info("Image: {}".format(sanitized_inference_image_name))
logging.info("Container name: {}".format(default_server_container_name))
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants