Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JsonNode.optional(String name) and optional(int index) methods #4866

Merged
merged 8 commits into from
Dec 30, 2024
Merged

Add JsonNode.optional(String name) and optional(int index) methods #4866

merged 8 commits into from
Dec 30, 2024

Conversation

JooHyukKim
Copy link
Member

resolves #2145

@cowtowncoder
Copy link
Member

Looks good, just want to ensure we use the best name (see note on #2145).

Would be good to perhaps spot check behavior for some other types (TextNode, NumberNode impls?) -- can modify assertNodeNumbers() in NodeTestBase (called by NumberNodesTest to cover number nodes I think.

@JooHyukKim
Copy link
Member Author

Would be good to perhaps spot check behavior for some other types (TextNode, NumberNode impls?) -- can modify assertNodeNumbers() in NodeTestBase (called by NumberNodesTest to cover number nodes I think.

Will do!

@cowtowncoder cowtowncoder added this to the 2.19.0 milestone Dec 30, 2024
@cowtowncoder cowtowncoder merged commit 9e63036 into FasterXML:2.19 Dec 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.19.0
Development

Successfully merging this pull request may close these issues.

Add JsonNode.optional(String name) and JsonNode.optional(int index) to be able to get an Optional JsonNode
2 participants
@JooHyukKim @cowtowncoder