Clean up BaseTest. Remove deprecated methods, warnings and etc...
#4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowtowncoder
reviewed
Oct 2, 2023
| } | ||
| } | ||
|
|
||
| public void testBeanMergingViaGlobal() throws Exception |
There was a problem hiding this comment.
I don't think this makes sense: moving JacksonFiveMinutesUser should be moved in PropertyMergeTest instead if that's the only usage.
Or, better. yet, move to com.fasterxml.jackson.databind.testutil where there is already MediaItem.
|
Removal of deprecated method is fine. But |
cowtowncoder
approved these changes
Oct 3, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification
JacksonInFiveMinutestutorial test case and class to its own test class.finalinprotected staticmethodquote()andaposToQuotes()method