Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T3D UI #389

Merged
merged 14 commits into from
Nov 10, 2024
Merged

T3D UI #389

merged 14 commits into from
Nov 10, 2024

Conversation

Lilaa3
Copy link
Collaborator

@Lilaa3 Lilaa3 commented Jul 24, 2024 •
edited
Loading

Implement UI for tiny 3d, the fast libdragon 3d microcode

@jesusyoshi54
Copy link
Collaborator

please provide a description :)

Yanis002
Yanis002 reviewed Aug 10, 2024
View reviewed changes
Copy link
Contributor

@Yanis002 Yanis002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here don't understand everything but here's my small code review

fast64_internal/f3d/f3d_gbi.py Outdated Show resolved Hide resolved
fast64_internal/f3d/f3d_material.py Show resolved Hide resolved
__init__.py Show resolved Hide resolved
@Dragorn421 Dragorn421 added enhancement New feature or request f3d Has to do with the "f3d" code common to all games labels Aug 20, 2024
Dragorn421
Dragorn421 reviewed Aug 20, 2024
View reviewed changes
Copy link
Contributor

@Dragorn421 Dragorn421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks alright, would need some reviews of how it looks in blender

@Dragorn421 Dragorn421 added the test please Ask that some other Fast64 dev tests the feature/... label Aug 20, 2024
@Dragorn421 Dragorn421 added this to the v2.4.0 milestone Aug 20, 2024
@Lilaa3
Copy link
Collaborator Author

Lilaa3 commented Sep 20, 2024

Has anyone tested? @HailToDodongo

@HailToDodongo
Copy link
Contributor

Tested it again and it works fine.
imo this can be merged, the ongoing discussion about the UI/settings would make their own PRs

@Dragorn421 Dragorn421 removed the test please Ask that some other Fast64 dev tests the feature/... label Nov 10, 2024
@Dragorn421 Dragorn421 merged commit b0bad2f into Fast-64:main Nov 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yanis002 Yanis002 Yanis002 left review comments

@Dragorn421 Dragorn421 Dragorn421 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request f3d Has to do with the "f3d" code common to all games
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Lilaa3 @jesusyoshi54 @HailToDodongo @Dragorn421 @Yanis002