-
-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Geocode API for searching places #583
Conversation
* feat: add types and docs for instance methods Authored-by: Dragos Strainu <[email protected]>
Hi, thanks for the PR. Would you mind giving me a little more background for the changes in this PR? What is the problem that you are trying to solve, and why is this the right solution? |
Hi! I'm sorry. We've been receiving charges for using atmosphere data and contact data even when we are sending the correct basic fields in the request. We don't know why and to avoid this we prefer using Geocode API because it gives us just the parameters we need: Maybe this could be useful for other developers! |
My understanding from looking at your code is that you want to provide an additional option in step 2, where instead of querying the Place Details API, you would query the Geocode API. Is this correct? Are you using the
In terms of merging this PR, I have a few questions.
|
Let me answer all your questions 😄
Yes! I meant the Place Details API, not Search, I'm sorry for the confusion.
Yes, I am. I'm only querying
Yes, Geocode API pricing is $4 every 1K requests for +100K requests per month and Place Details is $13,60 every 1K requests for 100K - 500K requests per month. For less than 100k request per month the cost is $5 and $17 respectively for every 1K requests.
No, actually, Geocoding API for details search only retrieves |
Thanks for the thorough explanations! At this point, I am inclined to wait until v2 to include this, as the functionality is technically available with the |
Thanks! When is the V2 gonna be released? Really looking forward to it! |
"When it's ready" is the standard open source answer. Feel free to take a look at the roadmap issue (#552) and create pulls against the v2 branch. |
@pamegonzalez just a quick note about choosing Geocode over Places api, Geocoding is not meant to return multiple queries and is not a replacement for Places API. From FAQ: https://developers.google.com/maps/documentation/geocoding/faq#trbl_component_filtering
I'm not sure if implement geocoding could be a good approach here, maybe in a different package could sounds better... |
This adds Geocode API for searching places as an alternative for place/search request.