Rebuild rows when predefined places change

[freeatnet]

This PR adds componentDidUpdate handler that will update the data source when the list of predefinedPlaces changes.

[tmeiss]

Fixes #495

[tmeiss]

@guilhermepontes this seems like a pretty common issue. Any chance we can merge in the near term?

[bell-steven]

Curious to know the use case behind this. Would you mind giving me some background on this?

[bell-steven]

I thought about this a bit. I think we might be better off filtering out the predefined places where the description is null or length === 0. If the description is blank, there is still a space (that was pressable) in the list.

[bell-steven]

I would add res = [ ...this.props.predefinedPlaces.filter( (place) => place.description && place.description.length, ), ];
in line 101, or something similar. It doesn't look like I can edit this PR, so let me know what you think about this and let's get this merged in.

[bell-steven]

@freeatnet can you address the comments above? Would like to get this merged.

[freeatnet]

@bell-steven I'm not sure I understand the logic of the changes you suggested. The patch I provided is a solution to the specific issue I was facing; if I were to implement this from scratch, I'd probably try to get rid of the description-matching logic of _getPredefinedPlace altogether.

[bell-steven]

@freeatnet the logic behind my change was to solve the problem you were facing, while making the behavior of the library consistent.

However, this method may return the wrong predefined place if multiple predefined places have no description

You mentioned that this was the specific issue your were solving with that line of code. When I tested it, I found that there would still be a blank row rendered in the list if the description was not set (and if there are a few blank rows, because they have a separating line between them, things get a little wonky).
I suggested a change, because I thought that it would solve both of those problems in one swoop.

Even if I were to remove the matching logic in _getPredefinedPlace, I think the issue of the blank rows would still remain.

I will note, there are plenty of parts of this library which can be simplified or stripped out. But, because there are so many little features, changes can have some nasty side effects. The goal is, over time, to try and simplify things here, but it doesn't happen overnight. See #552 for more.

[bell-steven]

Thanks for the PR!

Closed with 31f98b4