Add MOAsyncVectorEnv wrapper #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffelten
requested changes
Mar 10, 2025
There was a problem hiding this comment.
Thanks a lot 🚀
A simple feature that I'm sure will be very useful.
Overall, the implementation looks good to me :).
Could you please have a look at why pre-commit fails? Pro-tip: run pre-commit install in your terminal to trigger it locally for each commit.
Could you also implement a few tests so we're sure this thing runs? You can take inspiration from existing tests for MOSyncVectorEnv.
| if autoreset_mode == AutoresetMode.NEXT_STEP: | ||
| if autoreset: | ||
| observation, info = env.reset() | ||
| reward, terminated, truncated = np.zeros(reward_space.shape[0], dtype=np.float32), False, False |
There was a problem hiding this comment.
Would be useful for maintainance to annotate with a comment which lines have been modified compared to the original Gymnasium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful helper for my paper, helps speed up training over multiple environments via multiprocessing. Not sure if it is useful for current MORL-Baselines experiments but I'll just leave it here. Tested via the examples in the comment.