Skip to content

call toJSON only AFTER this.replacer #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

call toJSON only AFTER this.replacer #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/JsonStreamStringify.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,11 @@ export class JsonStreamStringify extends Readable {
}

setItem(value, parent: Item, key: string | number = '') {
// use replacer if applicable
if (this.replacer) {
value = this.replacer.call(parent.value, key, value);
}

// call toJSON where applicable
if (
value
Expand All @@ -195,11 +200,6 @@ export class JsonStreamStringify extends Readable {
value = value.toJSON(key);
}

// use replacer if applicable
if (this.replacer) {
value = this.replacer.call(parent.value, key, value);
}

// coerece functions and symbols into undefined
if (value instanceof Function || typeof value === 'symbol') {
value = undefined;
Expand Down