Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Drop support for PHP 7.4 #733

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/branch-alias.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: "Set up PHP"
uses: "shivammathur/setup-php@v2"
with:
php-version: "7.4"
php-version: "8.0"
coverage: "none"

- name: "Checkout code"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/coding-standards.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
matrix:
php-version:
- "7.4"
- "8.0"

steps:
- name: "Checkout code"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/static-analysis.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:

strategy:
matrix:
php-version: ["7.4"]
php-version: ["8.0"]

steps:
- name: "Checkout code"
Expand Down Expand Up @@ -55,7 +55,7 @@ jobs:

strategy:
matrix:
php-version: ["7.4"]
php-version: ["8.0"]

steps:
- name: "Checkout"
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ jobs:
experimental:
- false
php-version:
- "7.4"
- "8.0"
- "8.1"
- "8.2"
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## [Unreleased](https://github.com/FakerPHP/Faker/compare/v1.23.0...main)

- Dropped support for PHP 7.4 (#733)

## [2023-06-12, v1.23.0](https://github.com/FakerPHP/Faker/compare/v1.22.0..v1.23.0)

- Update `randomElements` to return random number of elements when no count is provided (#658)
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
}
],
"require": {
"php": "^7.4 || ^8.0",
"php": "^8.0",
"psr/container": "^1.0 || ^2.0",
"symfony/deprecation-contracts": "^2.2 || ^3.0"
},
Expand Down
28 changes: 9 additions & 19 deletions phpstan-baseline.neon
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
parameters:
ignoreErrors:
-
message: "#^Parameter \\#1 \\$input of function str_pad expects string, int given\\.$#"
message: "#^Parameter \\#1 \\$string of function str_pad expects string, int given\\.$#"
count: 1
path: src/Faker/Calculator/Iban.php

Expand Down Expand Up @@ -605,11 +605,6 @@ parameters:
count: 1
path: src/Faker/ORM/Spot/Populator.php

-
message: "#^Class UnitEnum not found\\.$#"
count: 2
path: src/Faker/Provider/Base.php

-
message: """
#^Instantiation of deprecated class Faker\\\\DefaultGenerator\\:
Expand All @@ -624,7 +619,7 @@ parameters:
path: src/Faker/Provider/Base.php

-
message: "#^Parameter \\#1 \\$input of function str_pad expects string, int given\\.$#"
message: "#^Parameter \\#1 \\$string of function str_pad expects string, int given\\.$#"
count: 1
path: src/Faker/Provider/Base.php

Expand Down Expand Up @@ -674,12 +669,12 @@ parameters:
path: src/Faker/Provider/Lorem.php

-
message: "#^Parameter \\#1 \\$str of function md5 expects string, int given\\.$#"
message: "#^Parameter \\#1 \\$string of function md5 expects string, int given\\.$#"
count: 1
path: src/Faker/Provider/Miscellaneous.php

-
message: "#^Parameter \\#1 \\$str of function sha1 expects string, int given\\.$#"
message: "#^Parameter \\#1 \\$string of function sha1 expects string, int given\\.$#"
count: 1
path: src/Faker/Provider/Miscellaneous.php

Expand Down Expand Up @@ -769,7 +764,7 @@ parameters:
path: src/Faker/Provider/en_NG/Address.php

-
message: "#^Parameter \\#1 \\$input of function str_pad expects string, int given\\.$#"
message: "#^Parameter \\#1 \\$string of function str_pad expects string, int given\\.$#"
count: 1
path: src/Faker/Provider/en_ZA/Person.php

Expand Down Expand Up @@ -894,12 +889,7 @@ parameters:
path: src/Faker/Provider/pt_PT/Address.php

-
message: "#^Left side of \\|\\| is always true\\.$#"
count: 1
path: src/Faker/Provider/pt_PT/Person.php

-
message: "#^Right side of \\|\\| is always false\\.$#"
message: "#^Binary operation \"\\*\" between string and int results in an error\\.$#"
count: 1
path: src/Faker/Provider/pt_PT/Person.php

Expand All @@ -909,7 +899,7 @@ parameters:
path: src/Faker/Provider/ro_RO/Person.php

-
message: "#^Parameter \\#1 \\$input of function str_pad expects string, int given\\.$#"
message: "#^Parameter \\#1 \\$string of function str_pad expects string, int given\\.$#"
count: 1
path: src/Faker/Provider/ru_RU/Company.php

Expand All @@ -929,7 +919,7 @@ parameters:
path: src/Faker/Provider/sv_SE/Municipality.php

-
message: "#^Parameter \\#1 \\$input of function str_pad expects string, int given\\.$#"
message: "#^Parameter \\#1 \\$string of function str_pad expects string, int given\\.$#"
count: 1
path: src/Faker/Provider/zh_CN/Address.php

Expand All @@ -939,7 +929,7 @@ parameters:
path: src/Faker/Provider/zh_CN/Address.php

-
message: "#^Parameter \\#1 \\$autoload_function of function spl_autoload_register expects callable\\(string\\)\\: void, Closure\\(mixed\\)\\: bool given\\.$#"
message: "#^Parameter \\#1 \\$callback of function spl_autoload_register expects \\(callable\\(string\\)\\: void\\)\\|null, Closure\\(mixed\\)\\: bool given\\.$#"
count: 1
path: src/autoload.php

Loading