forked from fzaninotto/Faker
-
Notifications
You must be signed in to change notification settings - Fork 346
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
9 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -289,4 +289,9 @@ public function __destruct() | |
{ | ||
$this->seed(); | ||
} | ||
|
||
public function __wakeup() | ||
{ | ||
$this->formatters = array(); | ||
} | ||
} |
fb44f85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird that in the original project the same change was made as breaking PHP 5.3 compatibility:
I came to this because I was using the original project (without composer.lock) and it had updated to 1.9.1->1.9.2 which is breaking change for PHP 5.3 in the original project:
As the original project is archived, can not report this via formal way,
I contacted @fzaninotto via email (on Dec 28 2020) that he remove 1.9.2 and optionally release 1.9.3 with a proper fix because it's semver incompatible change. But as none of such was done, I'm posting it here publicly in hope of better visibility.
and as this commit itself here seems to be without PR, leaving this in commit comment.
fb44f85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that this broke PHP 5.3 for you.
This was a coordinated security fix and I will not make any further changes to the 1.9 branch related to this.
Im sorry if this is an inconvenience for you. I would strongly recommend you to update your platform to a supported version of PHP. A workaround for you while you are updating PHP is to stick with version 1.9.1.
fb44f85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nyholm thank you for responding.
however, the message was directed to @fzaninotto, as fzaninotto/[email protected] is broken (this commit fzaninotto@848d812) the fork, fakerphp/[email protected] is okay (this commit: fb44f85)
fb44f85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everyone should switch to this package instead. It won't cause composer conflicts, even if your subdependencies depend on the original package, because we explicitly replace 1.9.2 of the old package with 1.9.2 of this package.
fb44f85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would vote against the upstream package doing anything. If anything this is helpful, highlighting the need for people to migrate to this package.