Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overriding with inheritance from overridden #15521

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EugenPolyakov
Copy link

@EugenPolyakov EugenPolyakov commented Jan 13, 2025

Allow overriding with inheritance from overridden.
Know issues:

  • the new element is always inherited from the last override (this is normal behavior now)
  • not tested with <clear> and topMostOverrideFile because it is not clear when and for what it is used

@Regalis11
Copy link
Collaborator

Thank you for the PR! It's worth noting that there's another PR that implements this, although it has been in the works since 2022 and is still a work in progress.

This seems like a vastly simpler implementation though - which makes me wonder if there are some edge cases that aren't taken into account here that would need more complex logic to solve. I don't have time to do a proper review on this right now, but I'll look into it in the future and try to think of potential edge cases or issues in the chosen approach though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants