Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added KVB Profile #28

Merged
merged 13 commits into from
Jun 13, 2023
Merged

Added KVB Profile #28

merged 13 commits into from
Jun 13, 2023

Conversation

1Maxnet1
Copy link
Contributor

As wished in #21 I implemented support for the KVB Profile. The format of the HAFAS-API is a bit different than the default so I had to override the Journey and the Journeys classes for the profile.
I also added some tests, at least for the requests and docs following the existing docs.

Please let me know any comments regarding the PR

Copy link
Member

@leona-ya leona-ya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a bug that came first up in this profile (I hope this was okay). Otherwise looks good :3

@leona-ya leona-ya merged commit e7bb642 into FahrplanDatenGarten:main Jun 13, 2023
@1Maxnet1 1Maxnet1 deleted the kvb-profile branch June 13, 2023 18:42
@1Maxnet1
Copy link
Contributor Author

1Maxnet1 commented Jun 13, 2023

I fixed a bug that came first up in this profile (I hope this was okay). Otherwise looks good :3

Thanks, sure this is okay 👍

@akloeckner
Copy link
Contributor

When browsing through the tests, I found that one test uses the VSN profile still:

client = HafasClient(VSNProfile())

@1Maxnet1
Copy link
Contributor Author

When browsing through the tests, I found that one test uses the VSN profile still:

client = HafasClient(VSNProfile())

Good catch, thanks. @leona-ya I would create a new PR as follow-up tomorrow morning, if you don't mind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants