-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added KVB Profile #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed a bug that came first up in this profile (I hope this was okay). Otherwise looks good :3
Thanks, sure this is okay 👍 |
When browsing through the tests, I found that one test uses the VSN profile still:
|
Good catch, thanks. @leona-ya I would create a new PR as follow-up tomorrow morning, if you don't mind :) |
As wished in #21 I implemented support for the KVB Profile. The format of the HAFAS-API is a bit different than the default so I had to override the Journey and the Journeys classes for the profile.
I also added some tests, at least for the requests and docs following the existing docs.
Please let me know any comments regarding the PR