Add error when attribute is present but value is nil and has no default #78
Conversation
| @@ -51,13 +51,15 @@ def raise_unauthorized(message = 'Unauthorized') | |||
| end | |||
|
|
|||
| def check_validation | |||
| fail Pavlov::ValidationError, "Missing arguments: #{missing_arguments.inspect}" if missing_arguments.any? | |||
There was a problem hiding this comment.
We probably want a line in UPGRADING to inform people that we will no longer raise this exact exception.
| !attribute.options.key?(:default) && send(attribute.name).nil? | ||
| def check_missing_arguments | ||
| attribute_set.each do |attribute| | ||
| if !attribute.options.key?(:default) && send(attribute.name).nil? |
There was a problem hiding this comment.
isn't there a way which checks whether the argument was passed in? This way you cannot pass in nil anywhere (except when this is an explicit default). That's no missing argument. We might want to check for nils as well, but I'm not totally sure. If there is no other way to check missing arguments this is fine though.
There was a problem hiding this comment.
When I originally wrote this code I couldn't find any way, but maybe the newer Virtus has more support for this. If nothing else, we could hook into the initializer now, and set all non-passed-in attributes to a AttributeNotGiven constant or something and then check for that here.
|
@tomdev what's happening with this PR? |
|
@tomdev Could you check this out? |
|
It still doesn't look like Virtus supports checking missing arguments. I like @marten his suggestion, but don't have time to work on it right now. |
No description provided.