[ready] [medium] Fix various issues with listelements and fabrikmodalrepeat form fields. #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sophist-UK
changed the title
Sophist-UK
changed the title
Sophist-UK
changed the title
Sophist-UK
force-pushed
the
listfields_intelligent_insert_mode-gui
branch
from
76ca73e
to
5794c7f
Compare
... e,g, in databasejoin element advanced tab for inserting description fields. 1. Position caret at end when initialising 2. Add whitespace as needed around value to avoid concatenation with existing strings. This is not a complete fix as e.g. if user positions caret in the middle of an element name, then inserting a new element name will split the existing one. This should probably be an HTML list field rather than a text field, but this is still better than existing.
... so that we can put the table back in the same place it came from when the fabrikmodalrepeat is closed.
Sophist-UK
force-pushed
the
listfields_intelligent_insert_mode-gui
branch
from
5794c7f
to
263efed
Compare
Sophist-UK
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intelligent insert into text field when mode=gui...
... e,g, in databasejoin element advanced tab for inserting description fields.
This is not a complete fix as e.g. if user positions caret in the middle of an element name, then inserting a new element name will split the
existing one. This should probably be an HTML list field rather than a text field, but this is still better than existing.
fabrikmodalrepeat not putting table back in same place as it came from
See #1961. Fixed in the PR.
listelements not handling ajax after fabrikmodalrepeat opened and closed.
See #1961 - causes not yet definitively identified and fix not included in this PR.