Fix #87 #89
Closed
Fix #87 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The checkstyle will be fixed soon |
|
Fixed, hopefully |
|
Thanks for the PR which helped outline the issue nicely, I however think this should be done a bit differently. I opened PR #90 since my approach is too different from yours. Please have a look and ideally a test if you can reproduce the original issue. |
|
Sounds good, this PR can be closed at any time if the other one works better. |
Carter-LL
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue Wrong remap of super method with local static method of same name #87, so using tiny remapper on Windows should work properly.
Fix code provided by my friend who is unable to create a GitHub account.