Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempted fix for #47 #65

Closed
wants to merge 6 commits into from
Closed

Attempted fix for #47 #65

wants to merge 6 commits into from

Conversation

Devan-Kerman
Copy link
Contributor

@Devan-Kerman Devan-Kerman commented Jul 9, 2021

Dunno if it actually works, might fix #47

@Devan-Kerman Devan-Kerman changed the title Attempted fix for https://github.com/FabricMC/tiny-remapper/issues/47 Attempted fix for #47 Jul 9, 2021
@Devan-Kerman
Copy link
Contributor Author

targetted wrong branch, bru

@Chocohead
Copy link
Contributor

Remember the inverse case of merging the multiple methods back into one, it's VM dependent if it lets you have duplicate methods in a class

@Devan-Kerman
Copy link
Contributor Author

Yea, I will prolly redo this PR, this approach is actually terrible anyways. Copying the entire method is a terrible solution, I should instead just call the other method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to remap class if two parents contain methods with same mapped name but different intermediary names
2 participants