Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reproducable zips across timezones. #952

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Fix reproducable zips across timezones. #952

merged 4 commits into from
Sep 11, 2023

Conversation

modmuss50
Copy link
Member

@modmuss50 modmuss50 commented Sep 9, 2023 •
edited
Loading

No description provided.

@modmuss50 modmuss50 added this to the 1.4 milestone Sep 9, 2023
@modmuss50 modmuss50 changed the title [WIP] Fix reproducable zips across timezones. Fix reproducable zips across timezones. Sep 9, 2023
@modmuss50 modmuss50 marked this pull request as ready for review September 9, 2023 22:50
@modmuss50
Copy link
Member Author

modmuss50 commented Sep 9, 2023 •
edited
Loading

Fixed, the root cause was using Febuary and not January...

This java commit here was very helpful in fixing and understanding this: openjdk/jdk@9913602

@modmuss50 modmuss50 linked an issue Sep 9, 2023 that may be closed by this pull request
Reproducible ZIP timestamps are dependent on machine timezone #926
Closed
@modmuss50 modmuss50 merged commit 1a4f765 into FabricMC:exp/1.4 Sep 11, 2023
73 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

Reproducible ZIP timestamps are dependent on machine timezone
1 participant
@modmuss50