Use hash of cache value as the JAR name for processed Minecraft JARs #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In basic testing, this cuts down the number of JARs to just one provided the same AWs are used on all subprojects
modmuss50
reviewed
Aug 17, 2023
.../fabricmc/loom/configuration/providers/minecraft/mapped/ProcessedNamedMinecraftProvider.java
Show resolved
Hide resolved
|
I have updated this PR to remove the old caching system as it should no longer be needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In basic testing, this cuts down the number of Minecraft JARs to just one provided the same AWs are used on all subprojects.
Note: this was quite literally the result of 5 minutes of experimentation, and likely has issues/unforeseen consequences. Please do not merge without more testing.