Made migrateMappings source-set aware and added an inPlace option #281
Conversation
There was a problem hiding this comment.
A few small things that stood out to me.
I was originally thinking each source set should be its own gradle task -- but loading, resolving, and merging mappings for every source set probably knocks out any efficiency gains that'd come from working in parallel.
This also fixes #246
|
|
||
| public MigrateMappingsTask() { | ||
| inputDir = getProject().file("src/main/java").toPath(); | ||
| outputDir = getProject().file("remappedSrc").toPath(); | ||
| sourceSets = new ArrayList<>(); |
There was a problem hiding this comment.
Why not use the Property and DomainObjectSet API? Gradle seems to be preferring that api for its newer tasks, and some portion of the API exists in 4.10 already: https://docs.gradle.org/4.10.2/userguide/lazy_configuration.html
| MappingSet mappingSet = loadMappingSet(mappings, mappingsProvider); | ||
|
|
||
| Path projectDir = project.getProjectDir().toPath(); | ||
| Path outputBaseDir = project.getBuildDir().toPath().resolve("remapped"); |
There was a problem hiding this comment.
This should probably match up with the name of the task -- mappingsMigrated or something?
Also would be good to make this configurable.
|
It's so far out of date, it doesn't make a lot of sense to update this 😓 |
No description provided.