-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Player Guides #5
Conversation
…into player-guides
compatibility
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a great start, just a few small points that I noticed.
**You must also ensure that you have played the version of Minecraft you want to use Fabric for at least once, otherwise the installer will not be able to find the version's files.** | ||
::: | ||
|
||
Once you've opened the installer, you should see a screen like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could likely do with a section to aid MacOS users as there is one extra step. I can write it, just not sure where to put it?
Is it possible to have a collapsed section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, through the usage of the details
block:
::: details [Title Here]
This is a details block.
:::
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor nitpicks, but overall good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to merge this, we can easily make changes to it later.
https://github.com/FabricMC/fabric-docs/pull/5/files#diff-6a6d58920e4c86c87bb4a3f15838d6b5c156b11269aabc26a1dc3813c251c5bcR72 |
Closes #4