Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player Guides #5

Merged
merged 26 commits into from
Jan 2, 2024
Merged

Player Guides #5

merged 26 commits into from
Jan 2, 2024

Conversation

IMB11
Copy link
Member

@IMB11 IMB11 commented Dec 29, 2023

Closes #4

@IMB11 IMB11 changed the title Player Guides A start on some player guides Dec 29, 2023
@IMB11 IMB11 added the new-content A new page or set of pages label Dec 29, 2023
@IMB11 IMB11 closed this Dec 29, 2023
@IMB11 IMB11 reopened this Dec 29, 2023
@IMB11 IMB11 marked this pull request as ready for review December 29, 2023 22:59
@IMB11 IMB11 requested review from a team as code owners December 29, 2023 22:59
players/faq.md Outdated Show resolved Hide resolved
players/finding-mods.md Outdated Show resolved Hide resolved
players/installing-java/windows.md Outdated Show resolved Hide resolved
players/finding-mods.md Show resolved Hide resolved
@FabricMC FabricMC deleted a comment from vercel bot Dec 29, 2023
Copy link

netlify bot commented Dec 30, 2023

Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit 34c71a9
🔍 Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/6590a3a2cc437e00084c7869
😎 Deploy Preview https://deploy-preview-5--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IMB11 IMB11 marked this pull request as draft December 30, 2023 13:03
@IMB11 IMB11 marked this pull request as ready for review December 30, 2023 15:00
@IMB11 IMB11 requested a review from modmuss50 December 30, 2023 15:00
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great start, just a few small points that I noticed.

players/installing-fabric.md Outdated Show resolved Hide resolved
players/installing-fabric.md Outdated Show resolved Hide resolved
**You must also ensure that you have played the version of Minecraft you want to use Fabric for at least once, otherwise the installer will not be able to find the version's files.**
:::

Once you've opened the installer, you should see a screen like this:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could likely do with a section to aid MacOS users as there is one extra step. I can write it, just not sure where to put it?

Is it possible to have a collapsed section?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, through the usage of the details block:

::: details [Title Here]
This is a details block.
:::

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

players/installing-java/linux.md Outdated Show resolved Hide resolved
players/installing-java/linux.md Outdated Show resolved Hide resolved
players/installing-mods.md Outdated Show resolved Hide resolved
players/installing-mods.md Outdated Show resolved Hide resolved
players/troubleshooting/crash-reports.md Outdated Show resolved Hide resolved
players/troubleshooting/uploading-logs.md Show resolved Hide resolved
players/faq.md Outdated Show resolved Hide resolved
players/faq.md Outdated Show resolved Hide resolved
players/faq.md Outdated Show resolved Hide resolved
players/finding-mods.md Outdated Show resolved Hide resolved
players/finding-mods.md Outdated Show resolved Hide resolved
players/installing-mods.md Outdated Show resolved Hide resolved
players/installing-mods.md Outdated Show resolved Hide resolved
players/installing-mods.md Outdated Show resolved Hide resolved
players/troubleshooting/crash-reports.md Outdated Show resolved Hide resolved
players/troubleshooting/uploading-logs.md Outdated Show resolved Hide resolved
@IMB11 IMB11 changed the title A start on some player guides Player Guides Dec 30, 2023
@IMB11 IMB11 requested a review from modmuss50 December 30, 2023 21:41
modmuss50
modmuss50 previously approved these changes Dec 30, 2023
Copy link

@Ecorous Ecorous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nitpicks, but overall good.

players/installing-java/linux.md Show resolved Hide resolved
players/installing-java/windows.md Show resolved Hide resolved
players/troubleshooting/uploading-logs.md Show resolved Hide resolved
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to merge this, we can easily make changes to it later.

@modmuss50 modmuss50 merged commit c6fdbbb into FabricMC:main Jan 2, 2024
6 checks passed
@IMB11 IMB11 deleted the player-guides branch February 11, 2024 19:52
@Snownee
Copy link

Snownee commented Oct 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-content A new page or set of pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Player Guides
5 participants