Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 page, localisation improvements #119

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

its-miroma
Copy link
Contributor

@its-miroma its-miroma commented Jun 20, 2024

  • Implement 404 page
  • Add more localisation strings
  • Show page authors who contributed outside GitHub
  • Update to latest vitepress-versioning-plugin version
  • Update scrollbar colors
  • Move LICENSE.md to LICENSE
  • Improve contributing.md file
  • Fix miscellaneous Markdown issues
    • Fix weird escapes in some translated links
    • Codec<Map> is getting out of hand
  • Add markdownlint-rule-search-replace rules
    • missing-heading-anchor: All headings must have anchors
    • no-absolute-links: No absolute links allowed
    • no-curly-quotes: No curly quotes allowed
    • no-file-extension-in-links: Links should not have an extension
    • no-multiple-spaces: Yeah, no multiple spaces,
    • no-punctuation-in-links: Punctuation should not be clickable
    • no-trailing-whitespace: Extend MD009 to code blocks

Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit be87d69
🔍 Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/668316ca8e82330008753580
😎 Deploy Preview https://deploy-preview-119--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IMB11 IMB11 added the framework This issue or pull request is related to the docs framework (vitepress). label Jun 20, 2024
@its-miroma its-miroma force-pushed the notfound branch 2 times, most recently from 0aca11c to a6031c3 Compare June 20, 2024 11:39
@IMB11 IMB11 added this to the MVP milestone Jun 23, 2024
@its-miroma its-miroma marked this pull request as ready for review June 23, 2024 20:24
@its-miroma its-miroma requested review from a team as code owners June 23, 2024 20:24
IMB11
IMB11 previously approved these changes Jun 24, 2024
- Implement 404 page
- Add more localisation strings
- Show page authors who contributed outside GitHub
- Update to latest `vitepress-versioning-plugin` version
- Update scrollbar colors
- Format with Prettier
`LICENSE` is not Markdown, so `markdownlint` would complain.
- Add GitHub flow instructions
- Correct port information
- Use appropriate Markdown features
- Drop extension from relative links (see <https://vitepress.dev/guide/routing#linking-between-pages>)
- Place punctuation outside of links
- Change `command` code blocks to `mcfunction`
- Change `bash` code blocks to `sh`
- Avoid technical term in `/develop/sounds/using-sounds.md` title
- Fix weird escapes in some translated links
- `Codec&amp;amp;lt;Map&amp;amp;gt;` is getting out of hand
- `missing-heading-anchor`: All headings must have anchors
- `no-absolute-links`: No absolute links allowed
- `no-curly-quotes`: No curly quotes allowed
- `no-file-extension-in-links`: Links should not have an extension
- `no-multiple-spaces`: Yeah, no multiple spaces,
- `no-punctuation-in-links`: Punctuation should not be clickable
- `no-trailing-whitespace`: Extend `MD009` to code blocks

Note: `markdownlint` rules do not apply for `translated/` files.
@its-miroma its-miroma force-pushed the notfound branch 2 times, most recently from adf507c to f484f88 Compare June 27, 2024 07:17
@IMB11 IMB11 added the merge-please This pull request is ready to merge label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework This issue or pull request is related to the docs framework (vitepress). merge-please This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants