-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
404 page, localisation improvements #119
Open
its-miroma
wants to merge
7
commits into
FabricMC:main
Choose a base branch
from
its-miroma:notfound
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
0aca11c
to
a6031c3
Compare
IMB11
previously approved these changes
Jun 24, 2024
5fbb412
to
3a3e505
Compare
- Implement 404 page - Add more localisation strings - Show page authors who contributed outside GitHub - Update to latest `vitepress-versioning-plugin` version - Update scrollbar colors - Format with Prettier
`LICENSE` is not Markdown, so `markdownlint` would complain.
- Add GitHub flow instructions - Correct port information - Use appropriate Markdown features
- Drop extension from relative links (see <https://vitepress.dev/guide/routing#linking-between-pages>) - Place punctuation outside of links - Change `command` code blocks to `mcfunction` - Change `bash` code blocks to `sh` - Avoid technical term in `/develop/sounds/using-sounds.md` title - Fix weird escapes in some translated links - `Codec&amp;lt;Map&amp;gt;` is getting out of hand
- `missing-heading-anchor`: All headings must have anchors - `no-absolute-links`: No absolute links allowed - `no-curly-quotes`: No curly quotes allowed - `no-file-extension-in-links`: Links should not have an extension - `no-multiple-spaces`: Yeah, no multiple spaces, - `no-punctuation-in-links`: Punctuation should not be clickable - `no-trailing-whitespace`: Extend `MD009` to code blocks Note: `markdownlint` rules do not apply for `translated/` files.
adf507c
to
f484f88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
framework
This issue or pull request is related to the docs framework (vitepress).
merge-please
This pull request is ready to merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vitepress-versioning-plugin
versionLICENSE.md
toLICENSE
contributing.md
fileCodec&amp;lt;Map&amp;gt;
is getting out of handmarkdownlint-rule-search-replace
rulesmissing-heading-anchor
: All headings must have anchorsno-absolute-links
: No absolute links allowedno-curly-quotes
: No curly quotes allowedno-file-extension-in-links
: Links should not have an extensionno-multiple-spaces
: Yeah, no multiple spaces,no-punctuation-in-links
: Punctuation should not be clickableno-trailing-whitespace
: ExtendMD009
to code blocks