Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Compatibility level" log to debug. #102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

modmuss50
Copy link
Member

@modmuss50 modmuss50 commented Feb 15, 2023

Finally annoyed me enough to make a PR, I dont think it provides meaningful enough info to always be logged.

Let me know if you disagree 👍

@liach
Copy link

liach commented May 5, 2023

I recall Mumfrey mentioned long ago that this CompatibilityLevel thing is quite useless. It should simply be taken care as part of the mod's java version requirements. And as I see, CompatibilityLevel and LanguageFeatures are quite in disarray and most likely isn't working as intended (outdated versions, incorrect max supported, incomplete language feature scan), I would recommend deprecating them altogether for an eventual removal (assuming mixin will still be alive by then)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants