dockerize plugin #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabienSalles
force-pushed
the
dockerised
branch
from
5c76a6c
to
214758d
Compare
diimpp
reviewed
Jan 7, 2021
|
|
||
| - | ||
| name: Run Behat | ||
| run: vendor/bin/behat --colors --strict -vvv --no-interaction || vendor/bin/behat --colors --strict -vvv --no-interaction --rerun | ||
| run: tests/Application/vendor/bin/behat --colors --strict -vvv --no-interaction || vendor/bin/behat --colors --strict -vvv --no-interaction --rerun |
There was a problem hiding this comment.
Second part of the command missing change of base path -- vendor/bin/behat --colors --strict -vvv --no-interaction --rerun
There was a problem hiding this comment.
Thanks, for your review :).
I disabled behat for the original plugin because I didn't have times allocate to this part.
if I have an answer to my issue on Sylius/PluginSkeleton#204 and if I have to improve it, I will fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.