Fix lsusb requests #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsusb tries to request the debug descriptor (0x0a) but does not fail if it is not available.
Fabien-Chouteau
requested changes
Jun 12, 2024
| @@ -159,8 +159,7 @@ package body USB.Device is | |||
| return Handled; | |||
|
|
|||
| when others => | |||
| raise Program_Error with "Descriptor not implemented " & | |||
| Desc_Type'Img; | |||
| Put_Line ("Descriptor not implemented:" & Desc_Type'Img); | |||
There was a problem hiding this comment.
We don't want any call to Put_Line if Verbose is not True.
There was a problem hiding this comment.
Put_Line in this file already checks if Verbose is set (see line 44). But maybe the procedure should be renamed to Log_Debug.
There was a problem hiding this comment.
@Fabien-Chouteau please suggest how to proceed.
Fabien-Chouteau
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsusb tries to request the debug descriptor (0x0a) but does not fail if it is not available.
See https://github.com/gregkh/usbutils/blob/master/lsusb.c#L2984