Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epilogue logging, new LED patterns, and simulated Drivetrain. #2

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

zeroClearAmerican
Copy link
Member

@zeroClearAmerican zeroClearAmerican commented Oct 30, 2024

WIP

This PR adds the following new 2025 features to the project:

  • Epilogue logging for DrivetrainSubsystem
  • Epilogue logging for VisionSubsystem
  • Built-in LED patterns and architecture
    • Needs testing to determine LED strip update method

Additional changes:

  • RobotContainer renamed to Container to avoid package collision with Epilogue autogenerated code
  • Simple swerve module sim implementation
  • Simple drivetrain sim implementation
  • New and improved VisionSubsystem
  • Better subsystem interaction structure, using function references between subsystems instead of holding on to subsystem references.

@zeroClearAmerican zeroClearAmerican self-assigned this Oct 30, 2024
@zeroClearAmerican zeroClearAmerican added the enhancement New feature or request label Oct 30, 2024
@zeroClearAmerican
Copy link
Member Author

Simulation showing incorrect data for custom struct types. Tracking issue here

zeroClearAmerican and others added 7 commits November 5, 2024 21:05
* Started implementing shooter interface (incomplete)

* Finished implementing ShooterIOReal

* General clean up and minor changes to the Shooter Subsytem. Also changed Shooter Subsytem creation in Container to pass through "isReal" (still commented out)

* Made Shooter Inputs and Outputs more readable and did more general cleanup

* Fixed misspelling "DriveIO" -> "ShooterIO"

* Condensed and simplified the setting of the inputs and outputs for the elevationSolenoid

* Added the getting of inputs and setting of outputs to ShooterSubsystem's periodic

* Made it so TalonSpeed and VictorSpeed are set to 0 in ShooterSubsystem.stopMotors() rather than ShooterIOReal.StopMotors() and made the motors only get set to a new value when needed (when the desired value differs from the current value)

* Removed unnecessary @parm from IShooterIO.StopMotors() JavaDoc

* Made it so m_previousTalonSpeed and m_previousVictorSpeed are set to 0 in ShooterIOReal.StopMotors() to prevent the motors from being set at the same time StopMotors() is being called

* Fixed logging in IShooterIO and uncommented the creation of ShooterSubsystem from Container

* Uncommented lines from Robot relating to ShooterSubsystem (in autonomousInit and teleopInit)

---------

Co-authored-by: ArrowVark <[email protected]>
Co-authored-by: Hudson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Epilogue "cannot be resolved or is not a field"
1 participant