Storm surge #91
Merged
Storm surge #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rezetta15
reviewed
Oct 30, 2024
| @@ -196,7 +198,9 @@ object Shooter { | |||
| val encoderConnected get() = inputs.absoluteEncoderConnected | |||
|
|
|||
| override fun periodic() { | |||
| val currentZero = zeroPos.getDouble(PivotIOKraken.ABSOLUTE_ENCODER_OFFSET.radians) | |||
| numTicks++ | |||
There was a problem hiding this comment.
assert(numTicks <= 20 && numTicks >=0)
rezetta15
reviewed
Oct 30, 2024
| @@ -264,7 +263,7 @@ class PivotIOKraken : PivotIO { | |||
| const val PROFILE_JERK = 80.0 | |||
|
|
|||
| val HARDSTOP_OFFSET: Rotation2d = Rotation2d.fromDegrees(-27.0) | |||
| val ABSOLUTE_ENCODER_OFFSET: Rotation2d = Rotation2d.fromDegrees(229.5) + HARDSTOP_OFFSET | |||
| val ABSOLUTE_ENCODER_OFFSET: Rotation2d = Rotation2d.fromDegrees(343.3) + HARDSTOP_OFFSET | |||
There was a problem hiding this comment.
where the hell did 343.3 come from? Explain in comment.
rezetta15
reviewed
Oct 30, 2024
| @@ -47,7 +46,7 @@ object Drivetrain : Subsystem, TalonFXStatusProvider { | |||
| /** Unit: Percent of max robot speed */ | |||
| private const val TRANSLATION_SENSITIVITY = 1.0 | |||
| /** Unit: Rotations per second */ | |||
| private const val ROTATION_SENSITIVITY = 0.9 | |||
| private const val ROTATION_SENSITIVITY = 1.25 | |||
There was a problem hiding this comment.
1.25 comes from getting joystick control that felt good to Calvin. Note this.
rezetta15
reviewed
Oct 30, 2024
| .whileTrue( | ||
| Shooter.Flywheels.intake() | ||
| ) | ||
| // Trigger(joystickLeft::getTrigger) |
There was a problem hiding this comment.
We can delete this, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.