Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data and generation scripts for irregular shapes (fixes #98) #132

Merged
merged 16 commits into from
Mar 12, 2025

Conversation

Rekyt
Copy link
Collaborator

@Rekyt Rekyt commented Mar 10, 2025

This PR aims to add irregular shapes for sites and provide ways of aggregating data on them.

It aims to tackle #98 and #123

@Rekyt
Copy link
Collaborator Author

Rekyt commented Mar 10, 2025

This PR still has to edit the upscaling vignette to adapt to the new aggregation function

@Rekyt Rekyt marked this pull request as ready for review March 11, 2025 22:33
@Rekyt Rekyt requested a review from ahasverus March 11, 2025 22:33
Copy link
Member

@ahasverus ahasverus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this huge work.

Just a question: I don't know if agg_grid (parameter name) is still appropriate now we can handle different input types (raster, polygons, etc.).

@Rekyt
Copy link
Collaborator Author

Rekyt commented Mar 12, 2025

Sure! I fell the same, what would be a good name?
aggregation_object seems to long
Something with "upscale" in the name? With "object"?

Could be transformed to agg_geom for aggregation geometry? Or target_geom for target geometry?
What do you think?

@ahasverus
Copy link
Member

Sure! I fell the same, what would be a good name? aggregation_object seems to long Something with "upscale" in the name? With "object"?

Could be transformed to agg_geom for aggregation geometry? Or target_geom for target geometry? What do you think?

I like agg_geom.

@ahasverus
Copy link
Member

Or maybe new_geom?

@Rekyt Rekyt merged commit 209f319 into main Mar 12, 2025
7 checks passed
@Rekyt Rekyt deleted the sites_different_shapes branch March 12, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants