Skip to content

Commit

Permalink
naming consistency #489
Browse files Browse the repository at this point in the history
  • Loading branch information
mck1117 committed Sep 18, 2024
1 parent e004101 commit e95ac81
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions firmware/controllers/actuators/electronic_throttle.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@ void EtbController::update() {
void EtbController::checkJam(percent_t setpoint, percent_t observation) {
float absError = std::abs(setpoint - observation);

auto jamDetectThreshold = engineConfiguration->jamDetectThreshold;
auto jamDetectThreshold = engineConfiguration->etbJamDetectThreshold;

if (jamDetectThreshold != 0) {
auto nowNt = getTimeNowNt();
Expand Down Expand Up @@ -828,7 +828,7 @@ void setDefaultEtbParameters() {
engineConfiguration->etb_iTermMin = -30;
engineConfiguration->etb_iTermMax = 30;

engineConfiguration->jamDetectThreshold = 10;
engineConfiguration->etbJamDetectThreshold = 10;
engineConfiguration->etbJamTimeout = 1;
}

Expand Down
2 changes: 1 addition & 1 deletion firmware/integration/rusefi_config.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1320,7 +1320,7 @@ float tChargeAirDecrLimit;Maximum allowed rate of decrease allowed for the estim

uint16_t autoscale fordInjectorSmallPulseBreakPoint;;"mg", 0.001, 0, 0, 65, 3

uint8_t jamDetectThreshold;;"%", 1, 0, 0, 50, 0
uint8_t etbJamDetectThreshold;;"%", 1, 0, 0, 50, 0

! Someday there will be a 6th option for BMW S55 that uses a separate shaft just for HPFP
#define hpfp_cam_e_enum "NONE", "Intake 1", "Exhaust 1", "Intake 2", "Exhaust 2"
Expand Down
2 changes: 1 addition & 1 deletion firmware/tunerstudio/tunerstudio.template.ini
Original file line number Diff line number Diff line change
Expand Up @@ -4225,7 +4225,7 @@ dialog = tcuControls, "Transmission Settings"
field = "Minimum ETB position", etbMinimumPosition
field = "Maximum ETB position", etbMaximumPosition
field = ""
field = "Jam detection error max", jamDetectThreshold
field = "Jam detection error max", etbJamDetectThreshold
field = "Jam detection timeout period", etbJamTimeout
field = "Disables jam detection for testing until the next power cycle"
commandButton = "Temporarily disable jam detection", cmd_etb_disable_jam_detect
Expand Down

0 comments on commit e95ac81

Please sign in to comment.