stable_21.11.x.FOME: backup domain reset re: FOME_STM32_LSE_MAX_WAIT #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also consider that the RTCSEL might have fallen back to the FOME_STM32_LSE_MAX_WAIT_RTCSEL when checking for backup domain reset rusefi@f3524fc
nmschulte
commented
Jan 16, 2025
| fomeLseCounter >= FOME_STM32_LSE_MAX_WAIT | ||
| && (RCC->BDCR & STM32_RTCSEL_MASK) != FOME_STM32_LSE_WAIT_MAX_RTCSEL | ||
| ) || fomeLseCounter < FOME_STM32_LSE_MAX_WAIT | ||
| && |
There was a problem hiding this comment.
I need to test building with these patches, but am concerned I might need parens around the sides of && here, which means reworking the macros/code as I can tell at the moment.
nmschulte
force-pushed
the
nms/lse-max_wait-bkp-domain-reset
branch
from
b4d702a to
bbf0c3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also consider that the RTCSEL might have fallen back to the FOME_STM32_LSE_MAX_WAIT_RTCSEL when checking for backup domain reset
rusefi#52