Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for SWIG 4.2.1 not creating ID methods #1234

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Fix for SWIG 4.2.1 not creating ID methods #1234

merged 1 commit into from
Oct 22, 2024

Conversation

Robadob
Copy link
Member

@Robadob Robadob commented Oct 2, 2024 •
edited
Loading

After this change, all tests (besides the 2 in #1233) pass.

Worth @ptheywood giving this a test build, to make sure I'm not fooling myself.

See #956 for more info

@Robadob Robadob requested a review from ptheywood October 2, 2024 19:29
@Robadob Robadob self-assigned this Oct 2, 2024
ptheywood
ptheywood approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@ptheywood ptheywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the ID methods (but 4.2.1 is still not fully usable as you found for #1233, which we need to sort before the next release)

@mondus mondus merged commit 345e0ae into master Oct 22, 2024
22 checks passed
@mondus mondus deleted the bugfix_swig_4.2.1 branch October 22, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptheywood ptheywood ptheywood approved these changes

Assignees

@Robadob Robadob

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Robadob @ptheywood @mondus