BugFix: Agent Python did not account for variable scope. #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mondus
previously approved these changes
Oct 27, 2023
|
Thanks
Will probably merge it after static graph
…On Fri, 27 Oct 2023, 13:57 mondus, ***@***.***> wrote:
***@***.**** approved this pull request.
This seems eminently sensible so happy for this to be merged. I cant think
of any scenario where this approach would not work.
—
Reply to this email directly, view it on GitHub
<#1127 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFVGCXMXTBIZZTZTMAKSR3YBOVVBAVCNFSM6AAAAAA6B7Y7O2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMBRG4ZTGMJZG4>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Robadob
force-pushed
the
network-message-v2
branch
from
d8dcc12
to
90a46ef
Compare
Robadob
force-pushed
the
bugfix_agent_python_scope
branch
from
cda52e1
to
9b50fd3
Compare
ptheywood
force-pushed
the
bugfix_agent_python_scope
branch
from
9b50fd3
to
79525da
Compare
ptheywood
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1125
Note: Current merges into #1089, as there was a possibility of conflict that I wished to avoid.