Skip to content

Portal - added to schedule tables sticky time coulums #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

TheCommandCat
Copy link
Contributor

Description

added to schedule tables sticky time coulums

( It might make sense visually to stick also the round column, but it could take up unnecessary space on small phone screens,
should we do it? )

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots

before

before

after

after

@johnmeshulam
Copy link
Member

Looking good, 2 small things:

  1. Take a look at how we can visually indicate that this column is sticky. IDK how frameworks usually do it but it's worth looking into.
  2. If we're editing the tables already, lets have the table containers occupy 100% width and only scroll inside the table. Right now we can scroll both the screen and the table which is a weird UX>

@TheCommandCat
Copy link
Contributor Author

  1. I thought of creating a side border that will make it more easy to understand(like google sheets and other sticky tables) but displaying it only while its not the first coulum will be weird, should we just move the time to be the first coulum and the round after + adding a little border to the left of it? ( I know its not the right order of things but I think it will make the UX a little better)

  2. while reading this I doubt a nice way to implement this while keeping the layout style with a little margin to the page but i will try to find solutions that would apply on phone displays only and still look reasonable.

@TheCommandCat
Copy link
Contributor Author

gif

@TheCommandCat
Copy link
Contributor Author

Hey, just updating I wasn’t able to reproduce the screen scrolling issue with the grid (unless you zoom in a lot). I tried making the grid fill the screen by adjusting the negative padding dynamically based on screen size, but it left mui grid border that I couldn’t remove, making it look even weirder. Personally, I think this is good enough, but do you have any improvements you’d still like me to try make?

@johnmeshulam
Copy link
Member

I'll need to test this locally to be sure, delaying this for now

@johnmeshulam johnmeshulam removed this from LEMS Apr 25, 2025
@johnmeshulam
Copy link
Member

@itamaroryan I don't like that the sticky column always has a shadow, I remember we talked about this last week but don't remember the outcome. If you have time to go through this again pls do 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants