Skip to content

Portal - added a search bar for teams in the event page #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

TheCommandCat
Copy link
Contributor

Description

Added a nice little autocomplete searchbar for teams names and numbers that redirects to the teams page :)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Screenshots

image
image

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings

@johnmeshulam
Copy link
Member

Let's place this search bar directly above the team list and not at the top of the page. Also - Did you check this on Mobile? for portal code please use iphont 14 pro max preset on devtools to verify responsivity

@TheCommandCat
Copy link
Contributor Author

Should be good now :)

Screenshots

image
image

@johnmeshulam
Copy link
Member

Thanks!! This looks a lot better now. Since we have the entire tam list below the search bar, we have no need to render a dropdown with autocomplete. Lets make the search bar filter out the list while we are typing.

Please take into account that the search function should be able to search by name number or affiliation and verify all these cases

@TheCommandCat
Copy link
Contributor Author

Hey, changed everything as you asked - Here is a visualization of the change :)

searchbar

@johnmeshulam johnmeshulam removed this from LEMS Apr 25, 2025
@johnmeshulam
Copy link
Member

@itamaroryan Can you please improve the UI here and review the PR? We can merge it afterwards

@johnmeshulam
Copy link
Member

Closing this since we are preparing for a big portal overhaul with support for teams across seasons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants