Merge pull request #5 from FINRAOS/hotfix-credibility

Hotfix credibility
FINRAOS · Aug 17, 2022 · 44a6876 · 44a6876
2 parents f9b31f8 + fb3505d
commit 44a6876
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/mvtk/credibility.py b/mvtk/credibility.py
@@ -22,9 +22,12 @@ def credible_interval(positive, negative, credibility=0.5, prior=(1, 1)):
     """
     positive += prior[0]
     negative += prior[1]
+    if not (positive > 1 or negative > 1):
+        raise ValueError(
+            "Credible intervals are only defined when at least one count + psueocount"
+            " is greater than 1"
+        )
     distribution = beta(positive, negative)
-    if positive + negative <= 0:
-        raise ValueError("Counts plus pseudocounts must be positive")
     mode = positive / (positive + negative)
     cdf_mode = distribution.cdf(mode)
     cred_2 = credibility / 2

diff --git a/mvtk/version.py b/mvtk/version.py
@@ -1 +1 @@
-__version__ = "0.1.2"
+__version__ = "0.1.3"
diff --git a/tests/credibility/test_credibility.py b/tests/credibility/test_credibility.py
@@ -14,8 +14,8 @@ def test_value_error():
 
 
 def test_equivalence():
-    assert credibility.credible_interval(0, 0) == credibility.credible_interval(
-        1, 1, prior=(0, 0)
+    assert credibility.credible_interval(0, 1) == credibility.credible_interval(
+        1, 2, prior=(0, 0)
     )