This repository has been archived by the owner on Jan 12, 2021. It is now read-only.
GeckoDriver Update #147
Open
GeckoDriver Update #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it's still failing, but apparently we should try to use a newer version of the jetty plugin: http://stackoverflow.com/questions/26496338/strange-java-lang-arrayindexoutofboundsexception-thrown-on-jetty-startup |
mmlinford
reviewed
May 24, 2017
| @@ -315,9 +304,7 @@ public ClientProperties(Map<String, String> options) { | |||
| * already contains the given key | |||
| */ | |||
| private final String load(String key, String defaultValue, String comment) { | |||
| if(options.containsKey(key)) { | |||
| return options.get(key); | |||
| } else if (config.getProperty(key) != null) { | |||
There was a problem hiding this comment.
We can't remove these lines (see 5680b8f)
mmlinford
reviewed
May 24, 2017
pom.xml
Outdated
| <groupId>org.mortbay.jetty</groupId> | ||
| <artifactId>jetty-maven-plugin</artifactId> | ||
| <version>8.1.14.v20131031</version> | ||
| <groupId>org.eclipse.jetty</groupId> |
There was a problem hiding this comment.
Don't change this version (it should use the one I added a few minutes ago to the main FINRAOS repo)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.