Add syntax highlight for double-bracketed parameters #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafeltra
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes task CIMPL-1098.
The pattern for double-bracketed parameters is within the context of an
insertrule with parameters, so double-brackets don't get highlighted in other situations. I tested this out with the insert rules with double-bracketed parameters used in SUSHI'sFSHImportertests. The lookbehind on the double-bracketbeginrules is needed to highlight correctly when double-brackets follow an escaped(or,character:In this rule, the double-brackets do not indicate a double-bracketed parameter. There is one parameter with value
123, [[oh no]].