Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 18 + Manifest Tweak #29

Closed
wants to merge 4 commits into from
Closed

Node 18 + Manifest Tweak #29

wants to merge 4 commits into from

Conversation

cmoesel
Copy link
Member

@cmoesel cmoesel commented Jan 31, 2024

This PR contains a few changes:

  • Removes node_modules from change control
  • Uses Node 18 by default
  • Updates manifest script to not assume a specific folder name
  • Updates manifest script to console log a summary of manifests

To test:

  • npm install then npm run build
  • Note the summary and note that only difference is timestamp
  • Add some new examples and remove some old examples
  • npm run build again
  • Note the differences highlighted in the summary and confirm index.json differences in diff

- Don't assume folder name is FSHOnline-Examples
- Log old and new manifest summaries
- Minor reformatting tweaks
@cmoesel
Copy link
Member Author

cmoesel commented Jan 31, 2024

Closed due to GitHub's insistence on running old GitHub Action. Will open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant