Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples for Logical models #28

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Conversation

mj-h
Copy link
Contributor

@mj-h mj-h commented Jan 30, 2024

This PR adds examples for Logical models.

FSHOnline: https://fshschool.org/FSHOnline/#/gist/3973a248e20b8063c3e2cb8d35fa470b

I don't have a lot of experience with Logical models, especially the Characteristics keyword, but my example compiles without errors.

However, there is 1 warning: Type characteristics code system not found. Skipping validation of characteristics for PetAsResourceLikeObject..

@cmoesel
Copy link
Member

cmoesel commented Jan 30, 2024

Thanks for the example. We will take a look!

Regarding the warning, I looked into it and that happens because FSH Online does not auto-load the special hl7.fhir.uv.tools#current package. This is because FSH Online does not support #current packages right now. When I run your examples locally using SUSHI (not FSH Online), there is no warning.

Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great example. I really like the way you walk through explaining logical models. And you stuck with the fish theme too! Fantastic!

Thank you for this. I've made one suggestion and pointed out one typo. Let me know what you think.

I also expected that our GitHub action would have automatically updated the index.json w/ this example, but it doesn't seem that happened. I'll look into that to see if I can figure it out.

Examples/Logicals/logical-example.fsh Outdated Show resolved Hide resolved
Examples/Logicals/logical-example.fsh Outdated Show resolved Hide resolved
Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thank you for your contribution!

Copy link
Collaborator

@jafeltra jafeltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new set of examples looks good to me. Thanks for contributing it!

@cmoesel cmoesel merged commit f5f62b4 into FHIR:main Feb 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants