Skip to content

Fix missing domain kwarg in pullback#361

Merged
jorgensd merged 1 commit intoFEniCS:mainfrom
firedrakeproject:pbrubeck/fix/piola-domain
Mar 21, 2025
Merged

Fix missing domain kwarg in pullback#361
jorgensd merged 1 commit intoFEniCS:mainfrom
firedrakeproject:pbrubeck/fix/piola-domain

Conversation

@pbrubeck
Copy link
Copy Markdown
Contributor

No description provided.

@jorgensd jorgensd added this pull request to the merge queue Mar 21, 2025
Merged via the queue into FEniCS:main with commit 8275654 Mar 21, 2025
11 of 12 checks passed
@michalhabera
Copy link
Copy Markdown
Contributor

What is the reason for this change? None of the FooPullback.apply() have the domain kwarg. So this is "missing" in what sense? I'd expect all other pullbacks that extract the domain from the expression require the same change then.

@pbrubeck
Copy link
Copy Markdown
Contributor Author

What is the reason for this change? None of the FooPullback.apply() have the domain kwarg. So this is "missing" in what sense? I'd expect all other pullbacks that extract the domain from the expression require the same change then.

What do you mean, all the Piola pullbacks do this, see here for example:

domain = domain or extract_unique_domain(expr)

@pbrubeck
Copy link
Copy Markdown
Contributor Author

This pullback was neglected by a recent PR #303 that introduced this new kwarg in apply().

@michalhabera
Copy link
Copy Markdown
Contributor

This pullback was neglected by a recent PR #303 that introduced this new kwarg in apply().

Ah, all good, I was looking at the UFL before that PR.

schnellerhase pushed a commit to schnellerhase/fenics-ufl that referenced this pull request Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants