Handle restrictions on MeshSequence#264
Merged
mscroggs merged 8 commits intoFEniCS:mainfrom Oct 15, 2025
Merged
Conversation
This was referenced Mar 27, 2024
Merged
e07f9fa to
d574909
Compare
e66d41d to
d3e72fb
Compare
ksagiyam
commented
Aug 21, 2024
23696eb to
ae55b3b
Compare
ae55b3b to
4ced3a7
Compare
7e4dd44 to
ef8fd99
Compare
jorgensd
reviewed
Jan 13, 2025
jorgensd
reviewed
Jan 13, 2025
988189f to
36559fc
Compare
36559fc to
9317b5b
Compare
9317b5b to
883ee0b
Compare
Member
|
Should this PR be closed in favour of #303? Or this a different feature? |
883ee0b to
2d76a5e
Compare
Contributor
Author
|
@jorgensd Could we possibly aim to merge this PR this week? I have following PRs, but it would be great to have this merged at least before coming Firedrake workshop. |
Member
I'd like some of the other developers to also have a look at this (at the change is rather big, and cascades into different corners of UFL). |
a0ae366 to
e82f3f1
Compare
9c380c1 to
bad931e
Compare
Contributor
Author
|
@jhale If time allows, could you have a look at this? |
bad931e to
67cf895
Compare
dham
approved these changes
Sep 26, 2025
… ...) on construction Co-authored-by: Pablo Brubeck <brubeck@protonmail.com>
* Add some type hints and simplify _extract_and_check_domain * Use future annotations and set ruff target
67cf895 to
e9e1eab
Compare
|
|
||
|
|
||
| def test_mixed_function_space_with_mesh_sequence_basic(): | ||
| @pytest.mark.skipif(sys.version_info >= (3, 14), reason="Hits recursion error on Python 3.14.0rc1 ") |
f5e4d98 to
69eaf16
Compare
Merged
0fc455f to
f52f7c6
Compare
jhale
approved these changes
Oct 15, 2025
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depend on #382 (small).
In multi-domain (submesh) problems, there are situations where, say, an exterior-facet integration of domainA is an interior-facet integration of domainB. In this PR we extend the
Measureclass to correctly represent such integration. Specifically, in the above example, if we choosedomainAas the "primal" integration domain, we define the interested measure as:. This required changing:
form.py),IntegralDatagrouping (algorithms/domain_analysis.py),signature(algorithms/signature.py),accordingly.
We also modified
RestrictionPropagatorclass andapply_restrictions()function.apply_restriction()function now takesdefault_restrictionskwarg, so that we can specify the default restrictions domain-wise. In the above case, we will have something like:.