-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python wrapper for FiniteElement.basix_element
#3624
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A concern/issue in the past has been how tightly we couple Basix Python objects and DOLFINx Python objetcs
We need to expose the basix element in some way (being wrapped as a basix python or c++ object), as we do not interface to all the functionality of the C++ element through As of now, there is not really any other alternative than using a basix element within DOLFINx. |
The required functionality can be wrapped. The change will force Basix and DOLFINx to use nanobind, and to use precisely the same nanobind version. Small changes were made previously when DOLFINx used nanobind and Basix still used pybind11 to allow this. It's good to avoid unnecessarily tight coupling. One of the reasons we wrap Basix elements on the DOLFINx side is to keep open the possibility of having a DOLFINx element that isn't backed by a Basix element. |
Switches to use the Basix python type for the returned element.
Ping #3553