Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW Submission from Emma Jehle #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions css/sytles.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
div.container {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ermajinkles this could have been written as .container { ... }, div .container is not necessary.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmjames thanks, for the notes. changed the tag

width: 736px;
margin: 0 auto;
}

h1 {
text-align: center;
padding: 20px;
background-color: yellow;
border-style: dashed;
border-width: 2px;
border-color: green;
margin-bottom: 0px;
font-family: 'Roboto Condensed', sans-serif;
}

nav {
text-align: right;
padding: 10px;
background-color: yellow;
border: 1px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ermajinkles This could have written as
nav { border: 1px dotted green; }

border-color: green;
border-style: dotted;
font-family: 'Roboto Condensed', sans-serif;
}

p {
text-align: left;
font-family: 'Roboto Condensed', sans-serif;
padding: 10px;
background-color: rgba(63, 191, 99, 0.50);
margin: 0px;
}

div.img {
padding: 15px;
}

a {
padding: 3px;
color: green;
}

footer {
font-family: 'Roboto Condensed', sans-serif;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ermajinkles in the future try to write rules that target the body { ... }. These styles will cascade and will be inherited down the stylesheet. For example
body { font-family: 'Roboto Condensed', sans-serif; }

background-color: yellow;
padding: 5px;
border: 1px;
border-color: green;
border-style: dotted;
margin-bottom: 0px;
}

div.list {
background-color: rgba(63, 191, 99, 0.50);
padding: 10px;
margin: 0px;
}
26 changes: 26 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<!DOCTYPE html>
<html>
<head>
<title>All About Jason Momoa</title>
<link href="css/sytles.css" type="text/css" rel="stylesheet"/>
<link href='https://fonts.googleapis.com/css?family=Roboto+Condensed:400,700,300' rel='stylesheet' type='text/css'>
</head>
<body>
<div class="container">
<h1>A Super Cool Page About Jason Momoa</h1>
<nav>
<a href="#">HOME/BIO</a>
<a href="interests.html">JASON'S INTERESTS</a>
</nav>
<div class="image">
<img src="pics/jason_momoa_1.jpg" alt="jason momoa smiling prolly thinking about his awesome wife, lisa bonet" title="jason momoa">
</div>
<div class="paragraph">
<p>Check out that sweet, sweet mug. That's the face of Jason Momoa &mdash; an American writer, director, actor, model and producer from Honolulu, Hawaii. He's probably most known for his role as Khal Drogo, son of Khal Bharbo on the HBO series "Game of Thrones."</p>
<p>Jason Momoa is married to Lisa Bonet and they have two kids. Learn more about Jason's interests<a href="#">here</a>or check out what <a href="https://en.wikipedia.org/wiki/Jason_Momoa">Wikipedia</a>has to say about him!
</p>
</div>
<footer>&copy; 2016 Emma Jehle. Made in Brooklyn.</footer>
</div>
</body>
</html>
33 changes: 33 additions & 0 deletions interests.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<!DOCTYPE html>
<html>
<head>
<title>Jason's Interests</title>
<link href="css/sytles.css" type="text/css" rel="stylesheet"/>
<link href='https://fonts.googleapis.com/css?family=Roboto+Condensed:400,700,300' rel='stylesheet' type='text/css'>
</head>
<body>
<div class="container">
<h1>Jason's Interests</h1>
<nav>
<a href="index.html">HOME/BIO</a>
<a href="#">JASON'S INTERESTS</a>
</nav>
<div class="image">
<img src="pics/momoa_bonet.jpg" alt="jason momoa and lisa bonet" title="one of the universe's sexiest couples">
</div>
<div class="list">
<p>Here's a list of things that Jason is likely interested in:</p>
<ul>
<li>Lisa Bonet</li>
<li><a href="https://www.instagram.com/p/BF4DEE7vHBb/?taken-by=prideofgypsies">His cool kids</a></li>
<li>Working out</li>
<li>Acting</li>
<li>World peace</li>
</ul>
</div>
<footer>&copy; 2016 Emma Jehle. Made in Brooklyn.</footer>
</div>


</body>
</html>
Binary file added pics/jason_momoa_1.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added pics/momoa_bonet.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.