Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build action to leverage generate artifact #129

Merged
merged 13 commits into from
Jun 1, 2024

Conversation

relent0r
Copy link
Contributor

@relent0r relent0r commented May 29, 2024

Description of changes
This PR updates the build action to leverage the generate artifact. It will trigger the generate action then use the artifact output in its processing. Then upload another artifact of its own output for deployment.

Testing method
Manual action requires to be taken on the default branch. Have tested with a push trigger to validate that the artifact and contents were created.

During testing you can see the actions being validated in my fork https://github.com/relent0r/spooky-db

closes #125

@relent0r relent0r marked this pull request as ready for review May 30, 2024 22:00
@relent0r
Copy link
Contributor Author

Only caveat is that I'm not 100% sure that it is replacing the existing files on artifact dl.

@Garanas Garanas mentioned this pull request May 31, 2024
@Garanas
Copy link
Member

Garanas commented May 31, 2024

Given:

Reviewing the output of ls -R before and after downloading the artifacts it should be fine now. The output of the artifact is flat, the app/data path is lost. We need to manually put them there again.

@Garanas
Copy link
Member

Garanas commented May 31, 2024

About running this particular workflow locally: it appears that it stalls on the powershell script. No matter what I do the CPU usage is near 0 and it appears to be doing nothing. Not even the initial printing (for the parameters) is in the console.

@relent0r relent0r merged commit 98d5ba6 into FAForever:master Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust the build action
2 participants