Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to re-compute the classification #115

Merged
merged 1 commit into from
Apr 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 43 additions & 7 deletions tools/cleaner.py
Original file line number Diff line number Diff line change
Expand Up @@ -414,17 +414,53 @@ def regroup_weapons(unit):
unit[u'Weapon'] = new_weapon_field
return True


def find_classification(unit):

if "MOBILE" in unit['Categories']:
if "ENGINEER" in unit['Categories']:
return 'RULEUC_Engineer'
if "COMMAND" in unit['Categories']:
return 'RULEUC_Commander'
if "COUNTERINTELLIGENCE" in unit['Categories']:
return 'RULEUC_CounterMeasure'
if "LAND" in unit['Categories']:
return 'RULEUC_MilitaryVehicle'
if "NAVAL" in unit['Categories']:
return 'RULEUC_MilitaryShip'
if "SUB" in unit['Categories']:
return 'RULEUC_MilitarySub'
if "AIR" in unit['Categories']:
return 'RULEUC_MilitarySub'

if "STRUCTURE" in unit['Categories']:
if "ENGINEER" in unit['Categories']:
return 'RULEUC_Engineer'
if "FACTORY"in unit['Categories']:
return "RULEUC_Factory"
if "DIRECTFIRE" in unit['Categories']:
return 'RULEUC_MilitaryStructure'
if "ANTIAIR" in unit['Categories']:
return 'RULEUC_MilitaryStructure'
if "INDIRECTFIRE" in unit['Categories']:
return 'RULEUC_MilitaryStructure'
if "ANTIMISSILE" in unit['Categories']:
return 'RULEUC_MilitaryStructure'
if "SHIELD" in unit['Categories']:
return 'RULEUC_MiscSupport'
if "RADAR" in unit['Categories']:
return 'RULEUC_Sensor'
if "OMNI" in unit['Categories']:
return 'RULEUC_Sensor'
if "SONAR" in unit['Categories']:
return 'RULEUC_Sensor'
return "RULEUC_Resource"

def fix_properties(unit_list):
"""
This function 'fixes' mistakes in unit properties - these are mostly faf bugs/typos/whatevers that
cause problems in the unitdb.
Function is separated to that it can be cleaned when these are fixed in faf sources
When we cleaned up the blueprint files we thought this field was not used. But here we are - two years later.
"""
for unit in unit_list:
# Give kennels the right classification: https://github.com/FAForever/fa/issues/2300
if unit['Id'] in ['XEB0104', 'XEB0204']:
unit['General']['Classification'] = 'RULEUC_Engineer'
unit['General']['Classification'] = find_classification(unit)


def run(app_path):
Expand Down
Loading