Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow joining public clans w/o invite token #428

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

bukajsytlos
Copy link
Member

No description provided.

@bukajsytlos bukajsytlos force-pushed the feature/public-clans-rebase-test branch from 45ecc4e to 2dff99a Compare December 6, 2020 12:23
@bukajsytlos bukajsytlos changed the title Feature/public clans rebase test Allow joining public clans w/o invite token Dec 6, 2020
@Brutus5000
Copy link
Member

Looks good. Needs adjustment and co-release on the website before merging.

@bukajsytlos bukajsytlos force-pushed the feature/public-clans-rebase-test branch from ffff903 to ca8e310 Compare June 4, 2023 19:58
@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Merging #428 (ca8e310) into develop (6c6f388) will increase coverage by 0.14%.
The diff coverage is 89.58%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #428      +/-   ##
=============================================
+ Coverage      77.00%   77.15%   +0.14%     
- Complexity      1225     1231       +6     
=============================================
  Files            249      249              
  Lines           3806     3844      +38     
  Branches         241      243       +2     
=============================================
+ Hits            2931     2966      +35     
- Misses           775      778       +3     
  Partials         100      100              
Impacted Files Coverage Δ
...IgnoreOctetStreamToObjectHttpMessageConverter.java 28.57% <ø> (ø)
...api/config/NoopMultipartFileToStringConverter.java 66.66% <ø> (ø)
...n/java/com/faforever/api/clan/ClansController.java 66.66% <50.00%> (+2.38%) ⬆️
...ava/com/faforever/api/voting/VotingController.java 9.09% <50.00%> (ø)
...rever/api/data/listeners/ClanEnricherListener.java 88.88% <75.00%> (-11.12%) ⬇️
...n/java/com/faforever/api/player/PlayerService.java 71.42% <75.00%> (+4.76%) ⬆️
.../main/java/com/faforever/api/clan/ClanService.java 100.00% <100.00%> (ø)
.../main/java/com/faforever/api/data/domain/Clan.java 100.00% <100.00%> (ø)
...c/main/java/com/faforever/api/error/ErrorCode.java 99.15% <100.00%> (+<0.01%) ⬆️
...ain/java/com/faforever/api/map/MapsController.java 68.18% <100.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c6f388...ca8e310. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants