Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #95 Create 404 Page #385

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bukajsytlos
Copy link
Member

@bukajsytlos bukajsytlos commented Mar 29, 2020

Closes #95 Create 404 Page

@bukajsytlos bukajsytlos changed the title Closes faf-java-api-95 Create 404 Page Closes #95 Create 404 Page Mar 29, 2020
<body>
<div class="background hero"></div>
<h1 class="primary-color" style="position: fixed; top: 30%; left: 20%;">You will get what you have asked for.
Nothing...</h1>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we had something more like supreme commander information.

Like:

There is nothing left, commander.

Or

We couldn't find the page for you, commander.

Or:

Dostya: No vodka found in the trunk...

etc...

<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.2.4/jquery.min.js"></script>
<link href="https://fonts.googleapis.com/css?family=Yanone+Kaffeesatz" rel="stylesheet" type="text/css">
<link href="https://faforever.com/styles/css/site.min.css" rel="stylesheet" type="text/css"/>
<link rel="stylesheet" th:href="@{/css/style.css}" type="text/css"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW: How does @{/css/style.css} works?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's some thymeleaf stuff

</head>
<body>
<div class="background hero"></div>
<h1 class="primary-color" style="position: fixed; top: 30%; left: 20%;">Oops... Something went wrong!</h1>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, more commander like stuff.

@Brutus5000
Copy link
Member

Just a few words on the state as discussed with bukajsytlos:

  1. We need dedicated 404 pages for html and for application/json
  2. We first want to check if we can serve a unified 404 page via our reverse proxy.
  3. Depending on traefiks capabilities we might need to implement the missing solution in the api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create 404 Page
3 participants