-
-
Notifications
You must be signed in to change notification settings - Fork 29
Update to Gradle 9.2.1 #1083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Gradle 9.2.1 #1083
Conversation
WalkthroughUpdates the Gradle wrapper from version 8.12.1 to 9.2.1 and refactors IDE test source configuration in build.gradle from using testSourceDirs list mutation to the testSources.from method, with no runtime behavior changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
build.gradle (1)
40-44: Modernize IDE test resources configuration alongside test sources.The
testSources.from()method is the modern API for configuring test sources in the IDEA plugin, replacing the deprecatedtestSourceDirsproperty. However, the integration test sourceset also includes test resources (line 57:resources.srcDir 'src/inttest/resources'), which should also be marked as test resources in the IDE for consistency.Apply this diff to mark both test sources and test resources:
idea { module { - testSources.from(file('src/inttest/java')) + testSources.from(file('src/inttest/java')) + testResources.from(file('src/inttest/resources')) } }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
build.gradle(1 hunks)gradle/wrapper/gradle-wrapper.properties(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: test
- GitHub Check: test
🔇 Additional comments (1)
gradle/wrapper/gradle-wrapper.properties (1)
3-3: Valid Gradle version upgrade with security validation enabled.Gradle 9.0.0 requires Java 17+ to run and your project targets Java 21, so this upgrade is compatible. The
testSources.from()method in the IDEA plugin is now available, which aligns with the build.gradle refactor in this PR.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.