-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply new binary patch to Salem #6499
base: develop
Are you sure you want to change the base?
Conversation
changelog/snippets/other.6499.md
Outdated
@@ -0,0 +1,23 @@ | |||
- (#6499) Apply new binary patch to Salem | |||
|
|||
Salem destroyer has special ability to move from water onto land. However in vanilla game this feature sometimes may cause problems with positioning of the unit and it's pathfinding. FAF introduced solution with a binary patch which makes it toggable ability to walk on land. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not copy-paste the pull request description into the changelog snippet. They do not share the same audience. For a pull request description your audience is other programmers and/or contributors who (soon) have a decent idea of how things work. For the changelog the audience is your average joe, they won't understand all the technical details and they don't have to.
I think you can simplify this to:
- (#6499) Fix hard crash when exiting the game when a Salem is on land
The Cybran Tech 2 Destroyer (Salem) has the special ability to move from water onto land. There was a bug in a special, alternative implementation introduced by FAForever. Together with an assembly patch this bug is now fixed.
Interested in how assembly patches work? Reach out to the game team. You can find us easiest via the official Discord server.
The above would be of category 'fix'. The below would be of category 'feature':
- (#6499) Enable dynamic footprint changes for (modded) units
With thanks to an assembly patch the footprint changes that were previously unique to the Cybran Tech 2 Destroyer can now be applied to any unit. For more details, see the pull request on GitHub.
Interested in how assembly patches work? Reach out to the game team. You can find us easiest via the official Discord server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not correct to call it dynamic footprint change. Because internally game still uses both of them based on motion type (if both are provided). Here we are just forcing to use only one in particular for water.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. @BlackYps do we want to include this in the release? One less hard crash to desktop is always nice.
Yes, this sounds like a good addition |
Salem destroyer has special ability to move from water onto land. However in vanilla game this feature sometimes may cause problems with positioning of the unit and it's pathfinding. FAF introduced solution with a binary patch which makes it toggable ability to walk on land.
But this solution had flaws:
With new assembly patch these flaws are no more. This PR is about applying new assmbly fix.
Description of the proposed changes
Applies patch changes and removes old ones.
Testing done on the proposed changes
GetStat
.Additional context
This change requires an asm patch.
Checklist